• Bjorn Helgaas's avatar
    PCI: Fix use of uninitialized MPS value · 1e358f94
    Bjorn Helgaas authored
    If "pcie_bus_config == PCIE_BUS_PERFORMANCE", we don't initialize "smpss",
    so we pass a pointer to garbage into pcie_bus_configure_set(), where we
    compute "mps" based on the garbage.  We then pass the garbage "mps" to
    pcie_write_mps(), which ignores it in the PCIE_BUS_PERFORMANCE case.
    
    Coverity isn't smart enough to deduce that we ignore the garbage (it's a
    lot to expect from a human, too), so initialize "smpss" to a safe value in
    all cases.
    
    Found by Coverity (CID 146454).
    Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    1e358f94
probe.c 51.5 KB