• Arnd Bergmann's avatar
    ext4: use BUG() instead of BUG_ON(1) · 1e83bc81
    Arnd Bergmann authored
    BUG_ON(1) leads to bogus warnings from clang when
    CONFIG_PROFILE_ANNOTATED_BRANCHES is set:
    
     fs/ext4/inode.c:544:4: error: variable 'retval' is used uninitialized whenever 'if' condition is false
          [-Werror,-Wsometimes-uninitialized]
                            BUG_ON(1);
                            ^~~~~~~~~
     include/asm-generic/bug.h:61:36: note: expanded from macro 'BUG_ON'
                                       ^~~~~~~~~~~~~~~~~~~
     include/linux/compiler.h:48:23: note: expanded from macro 'unlikely'
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     fs/ext4/inode.c:591:6: note: uninitialized use occurs here
            if (retval > 0 && map->m_flags & EXT4_MAP_MAPPED) {
                ^~~~~~
     fs/ext4/inode.c:544:4: note: remove the 'if' if its condition is always true
                            BUG_ON(1);
                            ^
     include/asm-generic/bug.h:61:32: note: expanded from macro 'BUG_ON'
                                   ^
     fs/ext4/inode.c:502:12: note: initialize the variable 'retval' to silence this warning
    
    Change it to BUG() so clang can see that this code path can never
    continue.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
    Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Reviewed-by: default avatarJan Kara <jack@suse.cz>
    1e83bc81
inode.c 180 KB