• Stefan Richter's avatar
    ieee1394: remove unused variables · 5030c807
    Stefan Richter authored
    which caused gcc 4.6 to warn about
        variable 'XYZ' set but not used.
    
    sbp2.c, unit_characteristics:
    
    The underlying problem which was spotted here --- an incomplete
    implementation --- is already 50% fixed in drivers/firewire/sbp2.c which
    observes mgt_ORB_timeout but not yet ORB_size.
    
    raw1394.c, length_conflict; dv1394.c, ts_off:
    
    Impossible to tell why these variables are there.  We can safely remove
    them though because we don't need a compiler warning to realize that we
    are dealing with (at least stylistically) flawed code here.
    
    dv1394.c, packet_time:
    
    This was used in debug macro that is only compiled in with
    DV1394_DEBUG_LEVEL >= 2 defined at compile-time.  Just drop it since
    nobody debugs dv1394 anymore.  Avoids noise in regular kernel builds.
    
    dv1394.c, ohci; eth1394.c, priv:
    
    These variables clearly can go away.  Somebody wanted to use them but
    then didn't (or not anymore).
    
    Note, all of this code is considered to be at its end of life and is
    thus not really meant to receive janitorial updates anymore.  But if we
    can easily remove noisy warnings from kernel builds, we should.
    Reported-by: default avatarJustin P. Mattock <justinmattock@gmail.com>
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    5030c807
eth1394.c 46.7 KB