• Hans de Goede's avatar
    platform/x86: intel-vbtn: Also handle tablet-mode switch on "Detachable" and... · 1fac39fd
    Hans de Goede authored
    platform/x86: intel-vbtn: Also handle tablet-mode switch on "Detachable" and "Portable" chassis-types
    
    Commit de9647ef ("platform/x86: intel-vbtn: Only activate tablet mode
    switch on 2-in-1's") added a DMI chassis-type check to avoid accidentally
    reporting SW_TABLET_MODE = 1 to userspace on laptops.
    
    Some devices with a detachable keyboard and using the intel-vbnt (INT33D6)
    interface to report if they are in tablet mode (keyboard detached) or not,
    report 32 / "Detachable" as chassis-type, e.g. the HP Pavilion X2 series.
    
    Other devices with a detachable keyboard and using the intel-vbnt (INT33D6)
    interface to report SW_TABLET_MODE, report 8 / "Portable" as chassis-type.
    The Dell Venue 11 Pro 7130 is an example of this.
    
    Extend the DMI chassis-type check to also accept Portables and Detachables
    so that the intel-vbtn driver will report SW_TABLET_MODE on these devices.
    
    Note the chassis-type check was originally added to avoid a false-positive
    tablet-mode report on the Dell XPS 9360 laptop. To the best of my knowledge
    that laptop is using a chassis-type of 9 / "Laptop", so after this commit
    we still ignore the tablet-switch for that chassis-type.
    
    Fixes: de9647ef ("platform/x86: intel-vbtn: Only activate tablet mode switch on 2-in-1's")
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Reviewed-by: default avatarMario Limonciello <Mario.limonciello@dell.com>
    Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    1fac39fd
intel-vbtn.c 8.32 KB