• Chris Wilson's avatar
    drm/i915/execlists: Mark up the racy access to switch_priority_hint · 23a44ae9
    Chris Wilson authored
    [ 7534.150687] BUG: KCSAN: data-race in __execlists_submission_tasklet [i915] / process_csb [i915]
    [ 7534.150706]
    [ 7534.150717] write to 0xffff8881f1bc24b4 of 4 bytes by task 24404 on cpu 3:
    [ 7534.150925]  __execlists_submission_tasklet+0x1158/0x2780 [i915]
    [ 7534.151133]  execlists_submit_request+0x2e8/0x2f0 [i915]
    [ 7534.151348]  submit_notify+0x8f/0xc0 [i915]
    [ 7534.151549]  __i915_sw_fence_complete+0x5d/0x3e0 [i915]
    [ 7534.151753]  i915_sw_fence_complete+0x58/0x80 [i915]
    [ 7534.151963]  i915_sw_fence_commit+0x16/0x20 [i915]
    [ 7534.152179]  __i915_request_queue+0x60/0x70 [i915]
    [ 7534.152388]  i915_gem_do_execbuffer+0x3997/0x4c20 [i915]
    [ 7534.152598]  i915_gem_execbuffer2_ioctl+0x2c3/0x580 [i915]
    [ 7534.152615]  drm_ioctl_kernel+0xe4/0x120
    [ 7534.152629]  drm_ioctl+0x297/0x4c7
    [ 7534.152642]  ksys_ioctl+0x89/0xb0
    [ 7534.152654]  __x64_sys_ioctl+0x42/0x60
    [ 7534.152667]  do_syscall_64+0x6e/0x2c0
    [ 7534.152681]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
    [ 7534.152693]
    [ 7534.152703] read to 0xffff8881f1bc24b4 of 4 bytes by interrupt on cpu 2:
    [ 7534.152914]  process_csb+0xe7c/0x10a0 [i915]
    [ 7534.153120]  execlists_submission_tasklet+0x30/0x170 [i915]
    [ 7534.153138]  tasklet_action_common.isra.0+0x42/0xa0
    [ 7534.153153]  __do_softirq+0xd7/0x2cd
    [ 7534.153166]  run_ksoftirqd+0x15/0x20
    [ 7534.153180]  smpboot_thread_fn+0x1ab/0x300
    [ 7534.153194]  kthread+0x19a/0x1e0
    [ 7534.153207]  ret_from_fork+0x1f/0x30
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: default avatarMika Kuoppala <mika.kuoppala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200309144249.10309-1-chris@chris-wilson.co.uk
    23a44ae9
intel_lrc.c 148 KB