• Michael Ellerman's avatar
    [PATCH] iseries_veth: Supress spurious WARN_ON() at module unload · 243cd55e
    Michael Ellerman authored
    My patch from a few weeks back (now in mainline), called "Cleanup skbs to
    prevent unregister_netdevice() hanging", can cause our TX timeout code to
    fire on machines with lots of VLANs (because it takes > 2 seconds between
    when we stop the queues and when we're finished stopping the connections).
    
    When that happens the TX timeout code freaks out and does a WARN_ON()
    because as far as it's concerned there shouldn't be a TX timeout happening,
    which is fair enough.
    
    I have a "proper" fix for this, which is to a) do refcounting on
    connections and b) implement a proper ack timer so we don't keep unacked
    skbs lying around for ever.  But for 2.6.12 I propose just supressing the
    WARN_ON().  Users will still see the "NETDEV WATCHDOG" warning, but that's
    not nearly as bad as a WARN_ON() which users interpret as an Oops.
    Signed-off-by: default avatarMichael Ellerman <michael@ellerman.id.au>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    243cd55e
iseries_veth.c 36.1 KB