• Katsuhiro Suzuki's avatar
    SoC: simple-card-utils: set 0Hz to sysclk when shutdown · 2458adb8
    Katsuhiro Suzuki authored
    This patch set 0Hz to sysclk when shutdown the card.
    
    Some codecs set rate constraints that derives from sysclk. This
    mechanism works correctly if machine drivers give fixed frequency.
    
    But simple-audio and audio-graph card set variable clock rate if
    'mclk-fs' property exists. In this case, rate constraints will go
    bad scenario. For example a codec accepts three limited rates
    (mclk / 256, mclk / 384, mclk / 512).
    
    Bad scenario as follows (mclk-fs = 256):
       - Initialize sysclk by correct value (Ex. 12.288MHz)
         - Codec set constraints of PCM rate by sysclk
           48kHz (1/256), 32kHz (1/384), 24kHz (1/512)
       - Play 48kHz sound, it's acceptable
       - Sysclk is not changed
    
       - Play 32kHz sound, it's acceptable
       - Set sysclk to 8.192MHz (= fs * mclk-fs = 32k * 256)
         - Codec set constraints of PCM rate by sysclk
           32kHz (1/256), 21.33kHz (1/384), 16kHz (1/512)
    
       - Play 48kHz again, but it's NOT acceptable because constraints
         do not allow 48kHz
    
    So codecs treat 0Hz sysclk as signal of applying no constraints to
    avoid this problem.
    Signed-off-by: default avatarKatsuhiro Suzuki <katsuhiro@katsuster.net>
    Link: https://lore.kernel.org/r/20190907174501.19833-1-katsuhiro@katsuster.netSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    2458adb8
simple-card-utils.c 14.9 KB