• Eric Dumazet's avatar
    virtio_net: remove ndo_poll_controller · 260dd2c3
    Eric Dumazet authored
    As diagnosed by Song Liu, ndo_poll_controller() can
    be very dangerous on loaded hosts, since the cpu
    calling ndo_poll_controller() might steal all NAPI
    contexts (for all RX/TX queues of the NIC). This capture
    can last for unlimited amount of time, since one
    cpu is generally not able to drain all the queues under load.
    
    virto_net uses NAPI for TX completions, so we better let core
    networking stack call the napi->poll() to avoid the capture.
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: "Michael S. Tsirkin" <mst@redhat.com>
    Cc: Jason Wang <jasowang@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    260dd2c3
virtio_net.c 81.6 KB