• Jan Kara's avatar
    quota: Fix bogus warning in dquot_disable() · 2700e606
    Jan Kara authored
    dquot_disable() was warning when sb_has_quota_loaded() was true when
    invalidating page cache for quota files. The thinking behind this
    warning was that we must have raced with somebody else turning quotas on
    and this should not happen because all places modifying quota state must
    hold s_umount exclusively now. However sb_has_quota_loaded() can be also
    true at this point when we are just suspending quotas on remount
    read-only. Just restore the behavior to situation before commit
    c3b00446 ("quota: Remove dqonoff_mutex") which introduced the
    warning.
    
    The code in dquot_disable() can be further simplified with the new
    locking of quota state changes however let's leave that to a separate
    commit that can get more testing exposure.
    
    Fixes: c3b00446Signed-off-by: default avatarJan Kara <jack@suse.cz>
    2700e606
dquot.c 78 KB