• Marcin Nowakowski's avatar
    uprobes: Fix uprobes on MIPS, allow for a cache flush after ixol breakpoint creation · 297e765e
    Marcin Nowakowski authored
    Commit:
    
      72e6ae28 ('ARM: 8043/1: uprobes need icache flush after xol write'
    
    ... has introduced an arch-specific method to ensure all caches are
    flushed appropriately after an instruction is written to an XOL page.
    
    However, when the XOL area is created and the out-of-line breakpoint
    instruction is copied, caches are not flushed at all and stale data may
    be found in icache.
    
    Replace a simple copy_to_page() with arch_uprobe_copy_ixol() to allow
    the arch to ensure all caches are updated accordingly.
    
    This change fixes uprobes on MIPS InterAptiv (tested on Creator Ci40).
    Signed-off-by: default avatarMarcin Nowakowski <marcin.nowakowski@imgtec.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Victor Kamensky <victor.kamensky@linaro.org>
    Cc: linux-mips@linux-mips.org
    Link: http://lkml.kernel.org/r/1481625657-22850-1-git-send-email-marcin.nowakowski@imgtec.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    297e765e
uprobes.c 49.8 KB