• Jarkko Sakkinen's avatar
    tpm: device class for tpm · 313d21ee
    Jarkko Sakkinen authored
    Added own device class for TPM. Uses MISC_MAJOR:TPM_MINOR for the
    first character device in order to retain backwards compatibility.
    Added tpm_dev_release() back attached to the character device.
    
    I've been running this code now for a while on my laptop (Lenovo
    T430S) TrouSerS works perfectly without modifications. I don't
    believe it breaks anything significantly.
    
    The sysfs attributes that have been placed under the wrong place
    and are against sysfs-rules.txt should be probably left to
    stagnate under platform device directory and start defining
    new sysfs attributes to the char device directory.
    
    Guidelines for future TPM sysfs attributes should be probably
    along the lines of
    
    - Single flat set of mandatory sysfs attributes. For example,
      current PPI interface is way way too rich when you only want
      to use it to clear and activate the TPM.
    
    - Define sysfs attribute if and only if there's no way to get
      the value from ring-3. No attributes for TPM properties. It's
      just unnecessary maintenance hurdle that we don't want.
    Signed-off-by: default avatarJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    Reviewed-by: default avatarJasob Gunthorpe <jason.gunthorpe@obsidianresearch.com>
    Reviewed-by: default avatarStefan Berger <stefanb@linux.vnet.ibm.com>
    Tested-by: default avatarScot Doyle <lkml14@scotdoyle.com>
    Tested-by: default avatarPeter Huewe <peterhuewe@gmx.de>
    Signed-off-by: default avatarPeter Huewe <peterhuewe@gmx.de>
    313d21ee
tpm-dev.c 4.43 KB