• Daniel Vetter's avatar
    drm/i915/tv: clear adjusted_mode.flags · 1062b815
    Daniel Vetter authored
    The native TV encoder has it's own flags to adjust sync modes and
    enabled interlaced modes which are totally irrelevant for the adjusted
    mode. This worked out nicely since the input modes used by both the
    load detect code and reported in the ->get_modes callbacks all have no
    flags set, and we also don't fill out any of them in the ->get_config
    callback.
    
    This changed with the additional sanitation done with
    
    commit 2960bc9c
    Author: Imre Deak <imre.deak@intel.com>
    Date:   Tue Jul 30 13:36:32 2013 +0300
    
        drm/i915: make user mode sync polarity setting explicit
    
    sinc now the "no flags at all" state wouldn't fit through core code
    any more. So fix this up again by explicitly clearing the flags in the
    ->compute_config callback.
    
    Aside: We have zero checking in place to make sure that the requested
    mode is indeed the right input mode we want for the selected TV mode.
    So we'll happily fall over if userspace tries to pull us.  But that's
    definitely work for a different patch series. So just add a FIXME
    comment for now.
    Reported-by: default avatarKnut Petersen <Knut_Petersen@t-online.de>
    Cc: Knut Petersen <Knut_Petersen@t-online.de>
    Cc: Imre Deak <imre.deak@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Tested-by: default avatarKnut Petersen <Knut_Petersen@t-online.de>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    1062b815
intel_tv.c 48 KB