• Cesar Eduardo Barros's avatar
    r6040: fix typo in use of MCR0 register bits · 77e1e438
    Cesar Eduardo Barros authored
    Commit 4e16d6eb (r6040: define more MCR0
    register bits) added #define values for MCR0 register bits and converted
    uses of hardcoded magic values to uses of these defines.
    
    However, one of the conversions looks suspicious:
    
     #define MCR0		0x00	/* Control register 0 */
    +#define  MCR0_RCVEN	0x0002	/* Receive enable */
    +#define  MCR0_XMTEN	0x1000	/* Transmission enable */
    
     	/* Init RDC private data */
    -	lp->mcr0 = 0x1002;
    +	lp->mcr0 = MCR0_XMTEN | MCR0;
    
    I believe what was meant here was MCR0_XMTEN | MCR0_RCVEN, which makes
    sense and matches the original values.
    Signed-off-by: default avatarCesar Eduardo Barros <cesarb@cesarb.net>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    77e1e438
r6040.c 32.7 KB