• Jarod Wilson's avatar
    [media] mceusb: mce_sync_in is brain-dead · 3a918aa6
    Jarod Wilson authored
    Aside from the initial "hey, lets make sure we've flushed any
    pre-existing data on the device" call to mce_sync_in, every other one of
    the calls was entirely superfluous. Ergo, remove them all, and rename
    the one and only (questionably) useful one to reflect what it really
    does. Verified on both gen2 and gen3 hardware to make zero difference.
    Well, except that you no longer get a bunch of urb submit failures from
    the unneeded mce_sync_in calls. Oh. And move that flush to a point
    *after* we've wired up the inbound urb, or it won't do squat. I have
    half a mind to just remove it entirely, but someone thought it was
    necessary at some point, and it doesn't seem to hurt, so lets leave it
    for the time being.
    
    This excercise took place due to insightful questions asked by Hans
    Petter Selasky, about the possible reuse of the inbound urb before it
    was actually availble by mce_sync_in, so thanks to him for motivating
    this cleanup.
    Reported-by: default avatarHans Petter Selasky <hselasky@c2i.net>
    Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    3a918aa6
mceusb.c 37.1 KB