• Miklos Szeredi's avatar
    [AF_UNIX]: Fix stream recvmsg() race. · 3c0d2f37
    Miklos Szeredi authored
    A recv() on an AF_UNIX, SOCK_STREAM socket can race with a
    send()+close() on the peer, causing recv() to return zero, even though
    the sent data should be received.
    
    This happens if the send() and the close() is performed between
    skb_dequeue() and checking sk->sk_shutdown in unix_stream_recvmsg():
    
    process A  skb_dequeue() returns NULL, there's no data in the socket queue
    process B  new data is inserted onto the queue by unix_stream_sendmsg()
    process B  sk->sk_shutdown is set to SHUTDOWN_MASK by unix_release_sock()
    process A  sk->sk_shutdown is checked, unix_release_sock() returns zero
    
    I'm surprised nobody noticed this, it's not hard to trigger.  Maybe
    it's just (un)luck with the timing.
    
    It's possible to work around this bug in userspace, by retrying the
    recv() once in case of a zero return value.
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@suse.cz>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    3c0d2f37
af_unix.c 48.2 KB