• Thomas Gleixner's avatar
    pinctrl: samsung: Remove bogus irq_[un]mask from resource management · 3fa53ec2
    Thomas Gleixner authored
    The irq chip callbacks irq_request/release_resources() have absolutely no
    business with masking and unmasking the irq.
    
    The core code unmasks the interrupt after complete setup and masks it
    before invoking irq_release_resources().
    
    The unmask is actually harmful as it happens before the interrupt is
    completely initialized in __setup_irq().
    
    Remove it.
    
    Fixes: f6a8249f ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Krzysztof Kozlowski <krzk@kernel.org>
    Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Cc: Linus Walleij <linus.walleij@linaro.org>
    Cc: Kukjin Kim <kgene@kernel.org>
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-samsung-soc@vger.kernel.org
    Cc: linux-gpio@vger.kernel.org
    Acked-by: default avatarTomasz Figa <tomasz.figa@gmail.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    3fa53ec2
pinctrl-exynos.c 18.2 KB