• Stefano Brivio's avatar
    ip6_fib: Don't discard nodes with valid routing information in fib6_locate_1() · 40cb35d5
    Stefano Brivio authored
    When we perform an inexact match on FIB nodes via fib6_locate_1(), longer
    prefixes will be preferred to shorter ones. However, it might happen that
    a node, with higher fn_bit value than some other, has no valid routing
    information.
    
    In this case, we'll pick that node, but it will be discarded by the check
    on RTN_RTINFO in fib6_locate(), and we might miss nodes with valid routing
    information but with lower fn_bit value.
    
    This is apparent when a routing exception is created for a default route:
     # ip -6 route list
     fc00:1::/64 dev veth_A-R1 proto kernel metric 256 pref medium
     fc00:2::/64 dev veth_A-R2 proto kernel metric 256 pref medium
     fc00:4::1 via fc00:2::2 dev veth_A-R2 metric 1024 pref medium
     fe80::/64 dev veth_A-R1 proto kernel metric 256 pref medium
     fe80::/64 dev veth_A-R2 proto kernel metric 256 pref medium
     default via fc00:1::2 dev veth_A-R1 metric 1024 pref medium
     # ip -6 route list cache
     fc00:4::1 via fc00:2::2 dev veth_A-R2 metric 1024 expires 593sec mtu 1500 pref medium
     fc00:3::1 via fc00:1::2 dev veth_A-R1 metric 1024 expires 593sec mtu 1500 pref medium
     # ip -6 route flush cache    # node for default route is discarded
     Failed to send flush request: No such process
     # ip -6 route list cache
     fc00:3::1 via fc00:1::2 dev veth_A-R1 metric 1024 expires 586sec mtu 1500 pref medium
    
    Check right away if the node has a RTN_RTINFO flag, before replacing the
    'prev' pointer, that indicates the longest matching prefix found so far.
    
    Fixes: 38fbeeee ("ipv6: prepare fib6_locate() for exception table")
    Signed-off-by: default avatarStefano Brivio <sbrivio@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    40cb35d5
ip6_fib.c 58.1 KB