• Julia Lawall's avatar
    iio: hid-sensor-accel-3d: Drop unnecessary static · 40f4b1f0
    Julia Lawall authored
    Drop static on a local variable, when the variable is initialized before
    use, on every possible execution path through the function.  The static has
    no benefit, and dropping it reduces the code size.
    
    The semantic patch that fixes this problem is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    // </smpl>
    
    The change in code size is indicates by the following output from the size
    command.
    
    before:
       text    data     bss     dec     hex filename
       3879     512       8    4399    112f drivers/iio/accel/hid-sensor-accel-3d.o
    
    after:
       text    data     bss     dec     hex filename
       3863     512       0    4375    1117 drivers/iio/accel/hid-sensor-accel-3d.o
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
    40f4b1f0
hid-sensor-accel-3d.c 13.8 KB