• Sagar Arun Kamble's avatar
    drm/i915: Handle log buffer flush interrupt event from GuC · 4100b2ab
    Sagar Arun Kamble authored
    GuC ukernel sends an interrupt to Host to flush the log buffer
    and expects Host to correspondingly update the read pointer
    information in the state structure, once it has consumed the
    log buffer contents by copying them to a file or buffer.
    Even if Host couldn't copy the contents, it can still update the
    read pointer so that logging state is not disturbed on GuC side.
    
    v2:
    - Use a dedicated workqueue for handling flush interrupt. (Tvrtko)
    - Reduce the overall log buffer copying time by skipping the copy of
      crash buffer area for regular cases and copying only the state
      structure data in first page.
    
    v3:
     - Create a vmalloc mapping of log buffer. (Chris)
     - Cover the flush acknowledgment under rpm get & put.(Chris)
     - Revert the change of skipping the copy of crash dump area, as
       not really needed, will be covered by subsequent patch.
    
    v4:
     - Destroy the wq under the same condition in which it was created,
       pass dev_piv pointer instead of dev to newly added GuC function,
       add more comments & rename variable for clarity. (Tvrtko)
    
    v5:
    - Allocate & destroy the dedicated wq, for handling flush interrupt,
      from the setup/teardown routines of GuC logging. (Chris)
    - Validate the log buffer size value retrieved from state structure
      and do some minor cleanup. (Tvrtko)
    - Fix error/warnings reported by checkpatch. (Tvrtko)
    - Rebase.
    
    v6:
     - Remove the interrupts_enabled check from guc_capture_logs_work, need
       to process that last work item also, queued just before disabling the
       interrupt as log buffer flush interrupt handling is a bit different
       case where GuC is actually expecting an ACK from host, which should be
       provided to keep the logging going.
       Sync against the work will be done by caller disabling the interrupt.
     - Don't sample the log buffer size value from state structure, directly
       use the expected value to move the pointer & do the copy and that cannot
       go wrong (out of bounds) as Driver only allocated the log buffer and the
       relay buffers. Driver should refrain from interpreting the log packet,
       as much possible and let Userspace parser detect the anomaly. (Chris)
    
    v7:
    - Use switch statement instead of 'if else' for retrieving the GuC log
      buffer size. (Tvrtko)
    - Refactored the log buffer copying function and shortended the name of
      couple of variables for better readability. (Tvrtko)
    
    v8:
    - Make the dedicated wq as a high priority one to further reduce the
      turnaround time of handing log buffer flush event from GuC.
    Signed-off-by: default avatarSagar Arun Kamble <sagar.a.kamble@intel.com>
    Signed-off-by: default avatarAkash Goel <akash.goel@intel.com>
    Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
    Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
    4100b2ab
i915_guc_submission.c 37.3 KB