• Simon Arlott's avatar
    [media] dvb-core: fix DVBFE_ALGO_HW retune bug · 45145b67
    Simon Arlott authored
    Commit 7e072221 breaks DVBFE_ALGO_HW tuning after a retune is requested,
    which causes bad tuning on my TBS 6920.
    
    [    0.769091] pci 0000:06:00.0: [14f1:8852] type 0 class 0x000400
    [   19.733530] CORE cx23885[0]: subsystem: 6920:8888, board: TurboSight TBS 6920 [card=14,autodetected]
    [  762.824912] cx24116_load_firmware: FW version 1.23.86.1
    
    7e072221 [media] dvb-core: Don't pass DVBv3 parameters on tune() fops
    
    Although re_tune is set to true when FESTATE_RETUNE occurs, it is never
    set back to false which the old code used to do when !FESTATE_RETUNE.
    
    This patch sets re_tune to false if !(state & FESTATE_RETUNE).
    
    $ szap-s2 -a 2 "Channel 5"
    reading channels from file '/home/simon/.szap/channels.conf'
    zapping to 247 'Channel 5':
    delivery DVB-S, modulation QPSK
    sat 0, frequency 10964 MHz H, symbolrate 22000000, coderate 5/6, rolloff 0.35
    vpid 0x092a, apid 0x092b, sid 0x092d
    using '/dev/dvb/adapter2/frontend0' and '/dev/dvb/adapter2/demux0'
    status 1f | signal cf40 | snr 0000 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr eccd | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr 0000 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr 0000 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr eccd | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr 0000 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr 0000 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr eb33 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr eccd | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr eccd | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr 0000 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr eccd | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr eccd | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cf40 | snr 0000 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cec0 | snr eccd | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    status 1f | signal cec0 | snr 0000 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
    Signed-off-by: default avatarSimon Arlott <simon@fire.lp0.eu>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    45145b67
dvb_frontend.c 64.9 KB