• Chris Metcalf's avatar
    timers: Fix get_next_timer_interrupt() computation · 46c8f0b0
    Chris Metcalf authored
    The tick_nohz_stop_sched_tick() routine is not properly
    canceling the sched timer when nothing is pending, because
    get_next_timer_interrupt() is no longer returning KTIME_MAX in
    that case.  This causes periodic interrupts when none are needed.
    
    When determining the next interrupt time, we first use
    __next_timer_interrupt() to get the first expiring timer in the
    timer wheel.  If no timer is found, we return the base clock value
    plus NEXT_TIMER_MAX_DELTA to indicate there is no timer in the
    timer wheel.
    
    Back in get_next_timer_interrupt(), we set the "expires" value
    by converting the timer wheel expiry (in ticks) to a nsec value.
    But we don't want to do this if the timer wheel expiry value
    indicates no timer; we want to return KTIME_MAX.
    
    Prior to commit 500462a9 ("timers: Switch to a non-cascading
    wheel") we checked base->active_timers to see if any timers
    were active, and if not, we didn't touch the expiry value and so
    properly returned KTIME_MAX.  Now we don't have active_timers.
    
    To fix this, we now just check the timer wheel expiry value to
    see if it is "now + NEXT_TIMER_MAX_DELTA", and if it is, we don't
    try to compute a new value based on it, but instead simply let the
    KTIME_MAX value in expires remain.
    
    Fixes: 500462a9 "timers: Switch to a non-cascading wheel"
    Signed-off-by: default avatarChris Metcalf <cmetcalf@mellanox.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: John Stultz <john.stultz@linaro.org>
    Link: http://lkml.kernel.org/r/1470688147-22287-1-git-send-email-cmetcalf@mellanox.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    46c8f0b0
timer.c 54.3 KB