• Dave Chinner's avatar
    xfs: Don't use reserved blocks for data blocks with DAX · 3b0fe478
    Dave Chinner authored
    Commit 1ca19157 ("xfs: Don't use unwritten extents for DAX") enabled
    the DAX allocation call to dip into the reserve pool in case it was
    converting unwritten extents rather than allocating blocks. This was
    a direct copy of the unwritten extent conversion code, but had an
    unintended side effect of allowing normal data block allocation to
    use the reserve pool. Hence normal block allocation could deplete
    the reserve pool and prevent unwritten extent conversion at ENOSPC,
    hence violating fallocate guarantees on preallocated space.
    
    Fix it by checking whether the incoming map from __xfs_get_blocks()
    spans an unwritten extent and only use the reserve pool if the
    allocation covers an unwritten extent.
    Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
    Tested-by: default avatarRoss Zwisler <ross.zwisler@linux.intel.com>
    Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
    3b0fe478
xfs_iomap.c 25.8 KB