• Namhyung Kim's avatar
    perf tools: Add file-handle feature test · 49f550ea
    Namhyung Kim authored
    The file handle (FHANDLE) support is configurable so some systems might not
    have it.  So add a config feature item to check it on build time so that we
    don't add the cgroup tracking feature based on that.
    
    Committer notes:
    
    Had to make the test use the same construct as its later use in
    synthetic-events.c, in the next patch in this series. i.e. make it be:
    
    	struct {
    		struct file_handle fh;
    		uint64_t cgroup_id;
    	} handle;
    
    To cope with:
    
        CC       /tmp/build/perf/util/cloexec.o
      util/synthetic-events.c:428:22: error: field 'fh' with   CC       /tmp/build/perf/util/call-path.o
      variable sized type 'struct file_handle' not at the end of a struct or class is a GNU
            extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
                      struct file_handle fh;
                                         ^
      1 error generated.
    
    Deal with this at some point, i.e. investigate if the right thing is to
    remove that -Wgnu-variable-sized-type-not-at-end from our CFLAGS, for
    now do the test the same way as it is used looks more sensible.
    Reported-by: default avatarArnaldo Carvalho de Melo <acme@kernel.org>
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20200402015249.3800462-1-namhyung@kernel.org
    [ split from a larger patch, removed blank line at EOF ]
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    49f550ea
Makefile.feature 8.17 KB