• Dmitry Torokhov's avatar
    USB: xhci - fix interval calculation for FS isoc endpoints · cd3c18ba
    Dmitry Torokhov authored
    Full-speed isoc endpoints specify interval in exponent based form in
    frames, not microframes, so we need to adjust accordingly.
    
    NEC xHCI host controllers will return an error code of 0x11 if a full
    speed isochronous endpoint is added with the Interval field set to
    something less than 3 (2^3 = 8 microframes, or one frame).  It is
    impossible for a full speed device to have an interval smaller than one
    frame.
    
    This was always an issue in the xHCI driver, but commit
    dfa49c4a "USB: xhci - fix math in
    xhci_get_endpoint_interval()" removed the clamping of the minimum value
    in the Interval field, which revealed this bug.
    
    This needs to be backported to stable kernels back to 2.6.31.
    Reported-by: default avatarMatt Evans <matt@ozlabs.org>
    Signed-off-by: default avatarDmitry Torokhov <dtor@vmware.com>
    Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
    Cc: stable@kernel.org
    cd3c18ba
xhci-mem.c 64.1 KB