• Ryusuke Konishi's avatar
    nilfs2: move out mark_inode_dirty calls from bmap routines · 9cb4e0d2
    Ryusuke Konishi authored
    Previously, nilfs_bmap_add_blocks() and nilfs_bmap_sub_blocks() called
    mark_inode_dirty() after they changed the number of data blocks.
    
    This moves these calls outside bmap outermost functions like
    nilfs_bmap_insert() or nilfs_bmap_truncate().
    
    This will mitigate overhead for truncate or delete operation since
    they repeatedly remove set of blocks.  Nearly 10 percent improvement
    was observed for removal of a large file:
    
     # dd if=/dev/zero of=/test/aaa bs=1M count=512
     # time rm /test/aaa
    
      real  2.968s -> 2.705s
    
    Further optimization may be possible by eliminating these
    mark_inode_dirty() uses though I avoid mixing separate changes here.
    Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    9cb4e0d2
bmap.c 13.9 KB