• Feifei Xu's avatar
    Btrfs: test_check_exists: Fix infinite loop when searching for free space entries · 5473e0c4
    Feifei Xu authored
    On a ppc64 machine using 64K as the block size, assume that the RB
    tree at btrfs_free_space_ctl->free_space_offset contains following
    two entries:
    
    1. A bitmap entry having an offset value of 0 and having the bits
       corresponding to the address range [128M+512K, 128M+768K] set.
    2. An extent entry corresponding to the address range
       [128M-256K, 128M-128K]
    
    In such a scenario, test_check_exists() invoked for checking the
    existence of address range [128M+768K, 256M] can lead to an
    infinite loop as explained below:
    
    - Checking for the extent entry fails.
    - Checking for a bitmap entry results in the free space info in
      range [128M+512K, 128M+768K] beng returned.
    - rb_prev(info) returns NULL because the bitmap entry starting from
      offset 0 comes first in the RB tree.
    - current_node = bitmap node.
    - while (current_node)
    	tmp = rb_next(bitmap_node);/*tmp is extent based free space entry*/
    	Since extent based free space entry's last address is smaller
    	than the address being searched for (i.e. 128M+768K) we
    	incorrectly again obtain the extent node as the "next right node"
    	of the RB tree and thus end up looping infinitely.
    
    This patch fixes the issue by checking the "tmp" variable which point
    to the most recently searched free space node.
    Reviewed-by: default avatarJosef Bacik <jbacik@fb.com>
    Reviewed-by: default avatarChandan Rajendra <chandan@linux.vnet.ibm.com>
    Signed-off-by: default avatarFeifei Xu <xufeifei@linux.vnet.ibm.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    5473e0c4
free-space-cache.c 91.7 KB