• Petr Machata's avatar
    net: sched: Do not drop root lock in tcf_qevent_handle() · 55f656cd
    Petr Machata authored
    Mirred currently does not mix well with blocks executed after the qdisc
    root lock is taken. This includes classification blocks (such as in PRIO,
    ETS, DRR qdiscs) and qevents. The locking caused by the packet mirrored by
    mirred can cause deadlocks: either when the thread of execution attempts to
    take the lock a second time, or when two threads end up waiting on each
    other's locks.
    
    The qevent patchset attempted to not introduce further badness of this
    sort, and dropped the lock before executing the qevent block. However this
    lead to too little locking and races between qdisc configuration and packet
    enqueue in the RED qdisc.
    
    Before the deadlock issues are solved in a way that can be applied across
    many qdiscs reasonably easily, do for qevents what is done for the
    classification blocks and just keep holding the root lock.
    Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    55f656cd
sch_red.c 13.6 KB