• Andrew Jeffery's avatar
    pinctrl: aspeed: g4: Fix mux configuration for GPIOs AA[4-7], AB[0-7] · 8ccb6dc6
    Andrew Jeffery authored
    Incorrect video output configuration bits were being tested on pins in
    GPIO banks AA and AB for the ROM{8,16} mux functions. The ROM{8,16}
    functions are the highest priority for the relevant pins and also the
    default function, so we require the relevant video output configuration
    be disabled to mux GPIO functionality. As the wrong bits were being
    tested a GPIO export would succeed but leave the pin in an unresponsive
    state (i.e. value updates were ignored).
    
    This misbehaviour was discovered as part of extending the GPIO
    controller's support to cover banks Y, Z, AA, AB and AC (AC in the case
    of the g5 SoC).
    
    Fixes: 6d329f14 ("pinctrl: aspeed-g4: Add mux configuration for all pins")
    Signed-off-by: default avatarAndrew Jeffery <andrew@aj.id.au>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    8ccb6dc6
pinctrl-aspeed-g4.c 75.2 KB