• Wu Fengguang's avatar
    writeback: avoid tiny dirty poll intervals · 5b9b3574
    Wu Fengguang authored
    The LKP tests see big 56% regression for the case fio_mmap_randwrite_64k.
    Shaohua manages to root cause it to be the much smaller dirty pause times
    and hence much more frequent invocations to the IO-less balance_dirty_pages().
    Since fio_mmap_randwrite_64k effectively contains both reads and writes,
    the more frequent pauses triggered more idling in the cfq IO scheduler.
    
    The solution is to increase pause time all the way up to the max 200ms
    in this case, which is found to restore most performance. This will help
    reduce CPU overheads in other cases, too.
    
    Note that I don't expect many performance critical workloads to run this
    access pattern: the mmap read-on-write is rather inefficient and could
    be avoided by doing normal writes syscalls.
    
    CC: Jan Kara <jack@suse.cz>
    CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Reported-by: default avatarLi Shaohua <shaohua.li@intel.com>
    Tested-by: default avatarLi Shaohua <shaohua.li@intel.com>
    Signed-off-by: default avatarWu Fengguang <fengguang.wu@intel.com>
    5b9b3574
page-writeback.c 64.4 KB