• Alexander Popov's avatar
    KVM: x86: Fix single-step debugging · 5cc244a2
    Alexander Popov authored
    The single-step debugging of KVM guests on x86 is broken: if we run
    gdb 'stepi' command at the breakpoint when the guest interrupts are
    enabled, RIP always jumps to native_apic_mem_write(). Then other
    nasty effects follow.
    
    Long investigation showed that on Jun 7, 2017 the
    commit c8401dda ("KVM: x86: fix singlestepping over syscall")
    introduced the kvm_run.debug corruption: kvm_vcpu_do_singlestep() can
    be called without X86_EFLAGS_TF set.
    
    Let's fix it. Please consider that for -stable.
    Signed-off-by: default avatarAlexander Popov <alex.popov@linux.com>
    Cc: stable@vger.kernel.org
    Fixes: c8401dda ("KVM: x86: fix singlestepping over syscall")
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    5cc244a2
x86.c 254 KB