• Christoph Hellwig's avatar
    [PATCH] further sim710 updates · 5d125f63
    Christoph Hellwig authored
    James, your sim710 changes look nice, but I think there's some more
    stuff to do in this driver.  I've started with the following (all
    untested due to lack of the hardware):
    
      - move to scsi_add_host/scsi_remove_host interface
      - remove a bunch of unneeded ifdefs
      - add missing statics
      - unregister driver templates on unload
    
    and I think there's more that should be done, but this would change
    user-visiable attributes:
    
      - remove the ugly single module option code and the command line
        parsing in favour of Rusty's new module_param stuff
      - split the driver into two drivers: 53c700_eisa and 53c700_mca.
        There's no logic shared between those two busses, just a little
        bit of helper in the setup/remove code
    
    And after looking a this driver I have some rants about the new
    mac/eisa code:
    
      - mca_register_driver/mca_unregister_driver should check for
        the precense of an MCA bus by themselves instead of leaving
        it to the caller
      - eisa_driver_register should really return 0 for sucess
      - mca_register_driver/mca_unregister_driver should be named
        mca_driver_register/mca_driver_unregister to be more similar
        to the other *driver_(un)registers.
    5d125f63
sim710.c 9.43 KB