• Johannes Berg's avatar
    iwlwifi: pcie: clarify RX queue need_update handling and locking · 5d63f926
    Johannes Berg authored
    When shadow registers are enabled, then need_update never needs
    to be set, so move the need_update handling into the function
    that really needs to do it (iwl_pcie_rxq_inc_wr_ptr) and also
    separate the check when it woke up. While at it, convert it to
    bool.
    
    This also clarifies the locking and means the irq_lock needs to
    no longer be held for any such updates.
    
    The irq_lock also doesn't have to be held for restocking since
    everything else locks the RX queue properly, so remove that and
    finally disentangle the two locks entirely so there aren't any
    dependencies between the two left.
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
    5d63f926
internal.h 15.1 KB