• Oleg Nesterov's avatar
    uprobes: Change handle_trampoline() to flush the frames invalidated by longjmp() · 5eeb50de
    Oleg Nesterov authored
    Test-case:
    
    	#include <stdio.h>
    	#include <setjmp.h>
    
    	jmp_buf jmp;
    
    	void func_2(void)
    	{
    		longjmp(jmp, 1);
    	}
    
    	void func_1(void)
    	{
    		if (setjmp(jmp))
    			return;
    		func_2();
    		printf("ERR!! I am running on the caller's stack\n");
    	}
    
    	int main(void)
    	{
    		func_1();
    		return 0;
    	}
    
    fails if you probe func_1() and func_2() because
    handle_trampoline() assumes that the probed function should must
    return and hit the bp installed be prepare_uretprobe(). But in
    this case func_2() does not return, so when func_1() returns the
    kernel uses the no longer valid return_instance of func_2().
    
    Change handle_trampoline() to unwind ->return_instances until we
    know that the next chain is alive or NULL, this ensures that the
    current chain is the last we need to report and free.
    
    Alternatively, every return_instance could use unique
    trampoline_vaddr, in this case we could use it as a key. And
    this could solve the problem with sigaltstack() automatically.
    
    But this approach needs more changes, and it puts the "hard"
    limit on MAX_URETPROBE_DEPTH. Plus it can not solve another
    problem partially fixed by the next patch.
    
    Note: this change has no effect on !x86, the arch-agnostic
    version of arch_uretprobe_is_alive() just returns "true".
    
    TODO: as documented by the previous change, arch_uretprobe_is_alive()
          can be fooled by sigaltstack/etc.
    Tested-by: default avatarPratyush Anand <panand@redhat.com>
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    Acked-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
    Acked-by: default avatarAnton Arapov <arapov@gmail.com>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/20150721134021.GA4773@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    5eeb50de
uprobes.c 48.5 KB