• Grazvydas Ignotas's avatar
    wl1251: fix elp_work race condition · 5f6722ee
    Grazvydas Ignotas authored
    While working on PS I've noticed elp_work is kicking rather often, and
    sometimes the chip is put to sleep before 5ms delay expires. This
    seems to happen because by the time wl1251_ps_elp_wakeup is called
    elp_work might still be pending. After wakeup is done, the processing
    may take some time, during which 5ms might expire and elp_work might
    get scheduled. In this case, ss soon as 1st thread finishes work and
    releases the mutex, elp_work will then put the device to sleep without
    5ms delay. In addition 1st thread will queue additional elp_work
    needlessly.
    
    Fix this by cancelling work in wl1251_ps_elp_wakeup instead.
    Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
    Acked-by: default avatarKalle Valo <kvalo@adurom.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    5f6722ee
ps.c 3.89 KB