• Takashi Sakamoto's avatar
    ALSA: firewire-digi00x: fix wrong reference count for stream functionality at... · 64582c56
    Takashi Sakamoto authored
    ALSA: firewire-digi00x: fix wrong reference count for stream functionality at error path of rawmidi interface
    
    In IEC 61883-6, several types of sampling data can be multiplexed into
    payload of common isochronous packet (CIP). For typical audio and music
    units, PCM samples and MIDI messages are multiplexed into one packet
    streaming.
    
    ALSA firewire-digi00x driver allows applications of rawmidi interface to
    start packet streaming for transmission of MIDI messages. However at
    error path, the reference count of stream functionality is not operated
    correctly. This can brings a bug that packet streaming is not stopped
    when all referrers release the count.
    
    This commit fixes the bug.
    
    Fixes: ae8ffbb2 ("ALSA: firewire-digi00x: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks")
    Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    64582c56
digi00x-midi.c 3.97 KB