• Li Zefan's avatar
    blktrace: fix output of BLK_TC_PC events · 66de7792
    Li Zefan authored
    BLK_TC_PC events should be treated differently with BLK_TC_FS events.
    
    Before this patch:
    
     # echo 1 > /sys/block/sda/sda1/trace/enable
     # echo pc > /sys/block/sda/sda1/trace/act_mask
     # echo blk > /debugfs/tracing/current_tracer
     # (generate some BLK_TC_PC events)
     # cat trace
            bash-2184  [000]  1774.275413:   8,7    I   N [bash]
            bash-2184  [000]  1774.275435:   8,7    D   N [bash]
            bash-2184  [000]  1774.275540:   8,7    I   R [bash]
            bash-2184  [000]  1774.275547:   8,7    D   R [bash]
     ksoftirqd/0-4     [000]  1774.275580:   8,7    C   N 0 [0]
            bash-2184  [000]  1774.275648:   8,7    I   R [bash]
            bash-2184  [000]  1774.275653:   8,7    D   R [bash]
     ksoftirqd/0-4     [000]  1774.275682:   8,7    C   N 0 [0]
            bash-2184  [000]  1774.275739:   8,7    I   R [bash]
            bash-2184  [000]  1774.275744:   8,7    D   R [bash]
     ksoftirqd/0-4     [000]  1774.275771:   8,7    C   N 0 [0]
            bash-2184  [000]  1774.275804:   8,7    I   R [bash]
            bash-2184  [000]  1774.275808:   8,7    D   R [bash]
     ksoftirqd/0-4     [000]  1774.275836:   8,7    C   N 0 [0]
    
    After this patch:
    
     # cat trace
            bash-2263  [000]   366.782149:   8,7    I   N 0 (00 ..) [bash]
            bash-2263  [000]   366.782323:   8,7    D   N 0 (00 ..) [bash]
            bash-2263  [000]   366.782557:   8,7    I   R 8 (25 00 ..) [bash]
            bash-2263  [000]   366.782560:   8,7    D   R 8 (25 00 ..) [bash]
     ksoftirqd/0-4     [000]   366.782582:   8,7    C   N (25 00 ..) [0]
            bash-2263  [000]   366.782648:   8,7    I   R 8 (5a 00 3f 00) [bash]
            bash-2263  [000]   366.782650:   8,7    D   R 8 (5a 00 3f 00) [bash]
     ksoftirqd/0-4     [000]   366.782669:   8,7    C   N (5a 00 3f 00) [0]
            bash-2263  [000]   366.782710:   8,7    I   R 8 (5a 00 08 00) [bash]
            bash-2263  [000]   366.782713:   8,7    D   R 8 (5a 00 08 00) [bash]
     ksoftirqd/0-4     [000]   366.782730:   8,7    C   N (5a 00 08 00) [0]
            bash-2263  [000]   366.783375:   8,7    I   R 36 (5a 00 08 00) [bash]
            bash-2263  [000]   366.783379:   8,7    D   R 36 (5a 00 08 00) [bash]
     ksoftirqd/0-4     [000]   366.783404:   8,7    C   N (5a 00 08 00) [0]
    
    This is what we do with PC events in user-space blktrace.
    Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
    Acked-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jens Axboe <jens.axboe@oracle.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    LKML-Reference: <49D32387.9040106@cn.fujitsu.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    66de7792
blktrace.c 37.8 KB