• Alex Elder's avatar
    libceph: avoid using freed osd in __kick_osd_requests() · 685a7555
    Alex Elder authored
    If an osd has no requests and no linger requests, __reset_osd()
    will just remove it with a call to __remove_osd().  That drops
    a reference to the osd, and therefore the osd may have been free
    by the time __reset_osd() returns.  That function offers no
    indication this may have occurred, and as a result the osd will
    continue to be used even when it's no longer valid.
    
    Change__reset_osd() so it returns an error (ENODEV) when it
    deletes the osd being reset.  And change __kick_osd_requests() so it
    returns immediately (before referencing osd again) if __reset_osd()
    returns *any* error.
    Signed-off-by: default avatarAlex Elder <elder@inktank.com>
    Reviewed-by: default avatarSage Weil <sage@inktank.com>
    685a7555
osd_client.c 55.5 KB