• Daniel W. S. Almeida's avatar
    media: dvb_dummy_fe: Fix ERROR: POINTER_LOCATION, AVOID_EXTERN and long lines · 6a168c6c
    Daniel W. S. Almeida authored
    Change foo* bar to foo *bar to avoid ERROR: POINTER_LOCATION in checkpatch
    
    ERROR: "foo* bar" should be "foo *bar"
    +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength)
    
    ERROR: "foo* bar" should be "foo *bar"
    +static int dvb_dummy_fe_read_signal_strength(struct dvb_frontend* fe, u16* strength)
    
    ERROR: "foo* bar" should be "foo *bar"
    +static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr)
    
    ERROR: "foo* bar" should be "foo *bar"
    +static int dvb_dummy_fe_read_snr(struct dvb_frontend* fe, u16* snr)
    
    ERROR: "foo* bar" should be "foo *bar"
    +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks)
    
    ERROR: "foo* bar" should be "foo *bar"
    +static int dvb_dummy_fe_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks)
    
    ERROR: "foo* bar" should be "foo *bar"
    +static int dvb_dummy_fe_sleep(struct dvb_frontend* fe)
    
    ERROR: "foo* bar" should be "foo *bar"
    +static int dvb_dummy_fe_init(struct dvb_frontend* fe)
    
    ERROR: "foo* bar" should be "foo *bar"
    +static void dvb_dummy_fe_release(struct dvb_frontend* fe)
    
    ERROR: "foo* bar" should be "foo *bar"
    +	struct dvb_dummy_fe_state* state = fe->demodulator_priv;
    
    ERROR: "foo* bar" should be "foo *bar"
    +struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void)
    
    ERROR: "foo* bar" should be "foo *bar"
    +	struct dvb_dummy_fe_state* state = NULL;
    
    ERROR: "foo* bar" should be "foo *bar"
    +	struct dvb_dummy_fe_state* state = NULL;
    
    ERROR: "foo* bar" should be "foo *bar"
    +	struct dvb_dummy_fe_state* state = NULL;
    
    remove 'extern' keyword from declaration
    
    Fix CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
    by removing it.
    
    Fix long lines
    
    Break long lines into smaller ones to improve readability.
    
    WARNING: line over 80 characters
    +	memcpy(&state->frontend.ops, &dvb_dummy_fe_ofdm_ops, sizeof(struct dvb_frontend_ops));
    
    WARNING: line over 80 characters
    +	memcpy(&state->frontend.ops, &dvb_dummy_fe_qpsk_ops, sizeof(struct dvb_frontend_ops));
    WARNING: line over 80 characters
    +	memcpy(&state->frontend.ops, &dvb_dummy_fe_qam_ops, sizeof(struct dvb_frontend_ops));
    
    WARNING: line over 80 characters
    +				FE_CAN_FEC_4_5 | FE_CAN_FEC_5_6 | FE_CAN_FEC_6_7 |
    
    WARNING: line over 80 characters
    +				FE_CAN_FEC_7_8 | FE_CAN_FEC_8_9 | FE_CAN_FEC_AUTO |
    
    WARNING: line over 80 characters
    +				FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_AUTO |
    
    WARNING: line over 80 characters
    +		.symbol_rate_min	= (57840000 / 2) / 6
    Suggested-by: default avatarShuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: default avatarDaniel W. S. Almeida <dwlsalmeida@gmail.com>
    Signed-off-by: default avatarSean Young <sean@mess.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    6a168c6c
dvb_dummy_fe.c 6.47 KB