• Frans Pop's avatar
    e1000e: avoid duplicated output of device name in kernel warning · 6c2a9efa
    Frans Pop authored
    With 2.6.27-rc3 I noticed the following messages in my boot log:
    
    0000:01:00.0: 0000:01:00.0: Warning: detected DSPD enabled in EEPROM
    0000:01:00.0: eth0: (PCI Express:2.5GB/s:Width x1) 00:16:76:04:ff:09
    
    The second seems correct, but the first has a silly repetition of the
    PCI device before the actual message. The message originates from
    e1000_eeprom_checks in e1000e/netdev.c.
    
    With this patch below the first message becomes
    
      e1000e 0000:01:00.0: Warning: detected DSPD enabled in EEPROM
    
    which makes it similar to directly preceding messages.
    
    Use dev_warn instead of e_warn in e1000_eeprom_checks() as the interface
    name has not yet been assigned at that point.
    
    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: default avatarFrans Pop <elendil@planet.nl>
    Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
    6c2a9efa
netdev.c 139 KB