• Govindarajulu Varadarajan's avatar
    enic: Fix format truncation warning · 7044f429
    Govindarajulu Varadarajan authored
    With -Wformat-truncation, gcc throws the following warning.
    
    Fix this by increasing the size of devname to accommodate 15 character
    netdev interface name and description.
    
    Remove length format precision for %s. We can fit entire name.
    
    Also increment the version.
    
    drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_open’:
    drivers/net/ethernet/cisco/enic/enic_main.c:1740:15: warning: ‘%u’ directive output may be truncated writing between 1 and 2 bytes into a region of size between 1 and 12 [-Wformat-truncation=]
         "%.11s-rx-%u", netdev->name, i);
                   ^~
    drivers/net/ethernet/cisco/enic/enic_main.c:1740:5: note: directive argument in the range [0, 16]
         "%.11s-rx-%u", netdev->name, i);
         ^~~~~~~~~~~~~
    drivers/net/ethernet/cisco/enic/enic_main.c:1738:4: note: ‘snprintf’ output between 6 and 18 bytes into a destination of size 16
        snprintf(enic->msix[intr].devname,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         sizeof(enic->msix[intr].devname),
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         "%.11s-rx-%u", netdev->name, i);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Signed-off-by: default avatarGovindarajulu Varadarajan <gvaradar@cisco.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7044f429
enic.h 8.17 KB