• Marcin Wojtas's avatar
    arm64: dts: marvell: add unique identifiers for Armada A8k SPI controllers · 8d897006
    Marcin Wojtas authored
    Enabling SPI controllers, which are attached to different busses
    inside an SoC, may result in overlapping enumeration and cause
    sysfs registration failure. Example log after enabling two
    controllers on Armada 8040 SoC with same identifiers:
    
    [    3.740415] sysfs: cannot create duplicate filename
    '/class/spi_master/spi0'
    [    3.747510] ------------[ cut here ]------------
    [    3.752145] WARNING: at fs/sysfs/dir.c:31
    [...]
    [    4.002299] orion_spi: probe of f4700600.spi failed with error -17
    
    spi-orion driver offers dedicated DT property ('cell-index'), that
    allow setting unique identifiers. Recently added support for CP110-slave
    HW block introduced two new SPI controllers' nodes with same ID as
    ones from CP110-master.
    
    This commit fixes the issue by assigning different 'cell-index' values
    for CP110-slave SPI controllers.
    
    Fixes: 4eef78a0 ("arm64: dts: marvell: add description for the slave
    CP110 in Armada 8K")
    Signed-off-by: default avatarMarcin Wojtas <mw@semihalf.com>
    Acked-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Signed-off-by: default avatarGregory CLEMENT <gregory.clement@free-electrons.com>
    8d897006
armada-cp110-slave.dtsi 7.44 KB