• Sean Paul's avatar
    drm: Fix HDCP failures when SRM fw is missing · 5fe89a6a
    Sean Paul authored
    The SRM cleanup in 79643fdd ("drm/hdcp: optimizing the srm
    handling") inadvertently altered the behavior of HDCP auth when
    the SRM firmware is missing. Before that patch, missing SRM was
    interpreted as the device having no revoked keys. With that patch,
    if the SRM fw file is missing we reject _all_ keys.
    
    This patch fixes that regression by returning success if the file
    cannot be found. It also checks the return value from request_srm such
    that we won't end up trying to parse the ksv list if there is an error
    fetching it.
    
    Fixes: 79643fdd ("drm/hdcp: optimizing the srm handling")
    Cc: stable@vger.kernel.org
    Cc: Ramalingam C <ramalingam.c@intel.com>
    Cc: Sean Paul <sean@poorly.run>
    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Cc: Maxime Ripard <mripard@kernel.org>
    Cc: Thomas Zimmermann <tzimmermann@suse.de>
    Cc: David Airlie <airlied@linux.ie>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: dri-devel@lists.freedesktop.org
    Reviewed-by: default avatarRamalingam C <ramalingam.c@intel.com>
    Signed-off-by: default avatarSean Paul <seanpaul@chromium.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200414190258.38873-1-sean@poorly.run
    
    Changes in v2:
    -Noticed a couple other things to clean up
    Reviewed-by: default avatarRamalingam C <ramalingam.c@intel.com>
    5fe89a6a
drm_hdcp.c 12 KB