• Himanshu Madhani's avatar
    scsi: qla2xxx: Fix sparse warning reported by kbuild bot · 0a36fd6c
    Himanshu Madhani authored
    this patch fixes following sparse warnings
    
     >> drivers/scsi/qla2xxx/qla_tmpl.c:873:32: sparse: sparse: incorrect type in assignment (different base types)
     >> drivers/scsi/qla2xxx/qla_tmpl.c:873:32: sparse:    expected unsigned int [usertype] capture_timestamp
     >> drivers/scsi/qla2xxx/qla_tmpl.c:873:32: sparse:    got restricted __le32 [usertype]
        drivers/scsi/qla2xxx/qla_tmpl.c:885:29: sparse: sparse: incorrect type in assignment (different base types)
     >> drivers/scsi/qla2xxx/qla_tmpl.c:885:29: sparse:    expected unsigned int
    
      vim +873 drivers/scsi/qla2xxx/qla_tmpl.c
    
      869
      870	static void
      871	qla27xx_time_stamp(struct qla27xx_fwdt_template *tmp)
      872	{
    > 873		tmp->capture_timestamp = cpu_to_le32(jiffies);
      874	}
      875
      876	static void
      877	qla27xx_driver_info(struct qla27xx_fwdt_template *tmp)
      878	{
      879		uint8_t v[] = { 0, 0, 0, 0, 0, 0 };
      880
      881		WARN_ON_ONCE(sscanf(qla2x00_version_str,
      882				    "%hhu.%hhu.%hhu.%hhu.%hhu.%hhu",
      883				    v+0, v+1, v+2, v+3, v+4, v+5) != 6);
      884
    > 885		tmp->driver_info[0] = cpu_to_le32(
      886			v[3] << 24 | v[2] << 16 | v[1] << 8 | v[0]);
      887		tmp->driver_info[1] = cpu_to_le32(v[5] << 8 | v[4]);
      888		tmp->driver_info[2] = __constant_cpu_to_le32(0x12345678);
      889	}
      890
    
    Link: https://lore.kernel.org/r/20200227201148.13973-1-hmadhani@marvell.com
    Fixes: a31056dd ("scsi: qla2xxx: Use endian macros to assign static fields in fwdump header")
    Reported-by: default avatarkbuild test robot <lkp@intel.com>
    Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    0a36fd6c
qla_tmpl.h 4.71 KB