• Eric Dumazet's avatar
    atl1c: Fix misuse of netdev_alloc_skb in refilling rx ring · 7b701764
    Eric Dumazet authored
    On Mon, 2013-07-29 at 08:30 -0700, Eric Dumazet wrote:
    > On Mon, 2013-07-29 at 13:09 +0100, Luis Henriques wrote:
    >
    > >
    > > I confirm that I can't reproduce the issue using this patch.
    > >
    >
    > Thanks, I'll send a polished patch, as this one had an error if
    > build_skb() returns NULL (in case sk_buff allocation fails)
    
    Please try the following patch : It should use 2K frags instead of 4K
    for normal 1500 mtu
    
    Thanks !
    
    [PATCH] atl1c: use custom skb allocator
    
    We had reports ( https://bugzilla.kernel.org/show_bug.cgi?id=54021 )
    that using high order pages for skb allocations is problematic for atl1c
    
    We do not know exactly what the problem is, but we suspect that crossing
    4K pages is not well supported by this hardware.
    
    Use a custom allocator, using page allocator and 2K fragments for
    optimal stack behavior. We might make this allocator generic
    in future kernels.
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Luis Henriques <luis.henriques@canonical.com>
    Cc: Neil Horman <nhorman@tuxdriver.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7b701764
atl1c_main.c 77.5 KB