• Nicholas Kazlauskas's avatar
    drm/amd/display: Don't set mode_changed=false if the stream was removed · 7e930949
    Nicholas Kazlauskas authored
    [Why]
    When switching from vt to desktop with EDID emulation we can receive
    an atomic commit such that we have a crtc where mode_changed = true.
    
    During the dm_update_crtc_state disable pass we remove the stream from
    the context and free it on the dm_new_crtc_state.
    
    During the enable pass we compare the new provisional stream to the
    dm_old_crtc_state->stream and determine that the stream is unchanged
    and no scaling has been changed.
    
    Following this, new_crtc_state->mode_changed is then set to false.
    The connectors haven't changed and the CRTC active state hasn't changed
    so drm_atomic_crtc_needs_modeset returns false, so we jump to
    skip_modeset and we hit:
    
    BUG_ON(dm_new_crtc_state->stream == NULL);
    
    ...since the old stream is gone from the context and the new stream is
    also still NULL.
    
    [How]
    Ensure that we still a stream to reuse before checking if we can reuse
    the old stream without a full modeset.
    Signed-off-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    7e930949
amdgpu_dm.c 198 KB