• Nikola Cornij's avatar
    drm/amd/display: Zero-out dsc init regs · 7f6e7186
    Nikola Cornij authored
    [why]
    Before a statically allocated PPS data structure, that did
    get zeroed-out at startup, had been re-used for making packed PPS
    SDP. With S3 fix, using a non-initialized PPS data structure was
    introduced, while wrongly assuming it'd get initialized before it's
    populated. As a consequence 'vbr_enable' and perhaps some other
    fields are left uninitialized when making packed PPS SDP. This can
    affect 'simple_422' as well because of the way PPS SDP packing is
    done (the fields are not masked first, only shifted). The behavior
    will be different, depending on the content of uninitialized data.
    
    [how]
    Zero-out PPS data structure at initialization time before it's
    populated
    
    Fixes: 1a9e3d45 ("drm/amd/display: Set DSC before DIG front-end is connected to its back-end")
    Signed-off-by: default avatarNikola Cornij <nikola.cornij@amd.com>
    Reviewed-by: default avatarWenjing Liu <Wenjing.Liu@amd.com>
    Acked-by: default avatarBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    7f6e7186
dcn20_dsc.c 29.5 KB