• Anup Patel's avatar
    RISC-V: Fix FIXMAP area corruption on RV32 systems · a256f2e3
    Anup Patel authored
    Currently, various virtual memory areas of Linux RISC-V are organized
    in increasing order of their virtual addresses is as follows:
    1. User space area (This is lowest area and starts at 0x0)
    2. FIXMAP area
    3. VMALLOC area
    4. Kernel area (This is highest area and starts at PAGE_OFFSET)
    
    The maximum size of user space aread is represented by TASK_SIZE.
    
    On RV32 systems, TASK_SIZE is defined as VMALLOC_START which causes the
    user space area to overlap the FIXMAP area. This allows user space apps
    to potentially corrupt the FIXMAP area and kernel OF APIs will crash
    whenever they access corrupted FDT in the FIXMAP area.
    
    On RV64 systems, TASK_SIZE is set to fixed 256GB and no other areas
    happen to overlap so we don't see any FIXMAP area corruptions.
    
    This patch fixes FIXMAP area corruption on RV32 systems by setting
    TASK_SIZE to FIXADDR_START. We also move FIXADDR_TOP, FIXADDR_SIZE,
    and FIXADDR_START defines to asm/pgtable.h so that we can avoid cyclic
    header includes.
    Signed-off-by: default avatarAnup Patel <anup.patel@wdc.com>
    Tested-by: default avatarAlistair Francis <alistair.francis@wdc.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarPaul Walmsley <paul.walmsley@sifive.com>
    a256f2e3
pgtable.h 11.2 KB