• Bjorn Helgaas's avatar
    MIPS: Remove "weak" from get_c0_compare_int() declaration · ec0b9d35
    Bjorn Helgaas authored
    Weak header file declarations are error-prone because they make every
    definition weak, and the linker chooses one based on link order (see
    10629d71 ("PCI: Remove __weak annotation from pcibios_get_phb_of_node
    decl")).
    
    get_c0_compare_int() is defined in several files.  Each definition is weak,
    so I assume Kconfig prevents two or more from being included.  The caller
    contains default code used when get_c0_compare_int() isn't defined at all.
    
    Add a weak get_c0_compare_int() definition with the default code and remove
    the weak annotation from the declaration.
    
    Then the platform implementations will be strong and will override the weak
    default.  If multiple platforms are ever configured in, we'll get a link
    error instead of calling a random platform's implementation.
    Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    Reviewed-by: default avatarJames Hogan <james.hogan@imgtec.com>
    Cc: Andrew Bresticker <abrestic@chromium.org>
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Patchwork: https://patchwork.linux-mips.org/patch/10686/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    ec0b9d35
time.h 2.13 KB