• Filipe David Borba Manana's avatar
    Btrfs: fix memory leaks on transaction commit failure · 80d94fb3
    Filipe David Borba Manana authored
    Structures of the types tree_mod_elem and qgroup_update are allocated
    during transaction commit but were not being released if the call to
    btrfs_run_delayed_items() returned an error.
    
    Stack trace reported by kmemleak:
    
    unreferenced object 0xffff880679f0b398 (size 128):
      comm "umount", pid 21508, jiffies 4295967793 (age 36718.112s)
      hex dump (first 32 bytes):
        60 b5 f0 79 06 88 ff ff 00 00 00 00 00 00 00 00  `..y............
        00 00 00 00 00 00 00 00 50 1c 00 00 00 00 00 00  ........P.......
      backtrace:
        [<ffffffff81742d26>] kmemleak_alloc+0x26/0x50
        [<ffffffff811889c2>] kmem_cache_alloc_trace+0x112/0x200
        [<ffffffffa046f2d3>] tree_mod_log_insert_key.constprop.45+0x93/0x150 [btrfs]
        [<ffffffffa04720f9>] __btrfs_cow_block+0x299/0x4f0 [btrfs]
        [<ffffffffa0472510>] btrfs_cow_block+0x120/0x1f0 [btrfs]
        [<ffffffffa0476679>] btrfs_search_slot+0x449/0x930 [btrfs]
        [<ffffffffa048eecf>] btrfs_lookup_inode+0x2f/0xa0 [btrfs]
        [<ffffffffa04eb49c>] __btrfs_update_delayed_inode+0x1c/0x1d0 [btrfs]
        [<ffffffffa04eb9e2>] __btrfs_run_delayed_items+0x162/0x1e0 [btrfs]
        [<ffffffffa04eba63>] btrfs_delayed_inode_exit+0x3/0x20 [btrfs]
        [<ffffffffa0499c63>] btrfs_commit_transaction+0x203/0xa50 [btrfs]
        [<ffffffffa046b519>] btrfs_sync_fs+0x69/0x110 [btrfs]
        [<ffffffff811cb210>] __sync_filesystem+0x30/0x60
        [<ffffffff811cb2bb>] sync_filesystem+0x4b/0x70
        [<ffffffff8119ce7b>] generic_shutdown_super+0x3b/0xf0
        [<ffffffff8119cfc6>] kill_anon_super+0x16/0x30
    unreferenced object 0xffff880677e0dd88 (size 32):
      comm "umount", pid 21508, jiffies 4295967793 (age 36718.112s)
      hex dump (first 32 bytes):
        78 75 11 a9 06 88 ff ff 00 c0 e0 77 06 88 ff ff  xu.........w....
        40 c3 a2 70 06 88 ff ff 00 00 00 00 00 00 00 00  @..p............
      backtrace:
        [<ffffffff81742d26>] kmemleak_alloc+0x26/0x50
        [<ffffffff811889c2>] kmem_cache_alloc_trace+0x112/0x200
        [<ffffffffa04fa54f>] btrfs_qgroup_record_ref+0xf/0x90 [btrfs]
        [<ffffffffa04e1914>] btrfs_add_delayed_tree_ref+0xf4/0x170 [btrfs]
        [<ffffffffa048518a>] btrfs_free_tree_block+0x9a/0x220 [btrfs]
        [<ffffffffa0472163>] __btrfs_cow_block+0x303/0x4f0 [btrfs]
        [<ffffffffa0472510>] btrfs_cow_block+0x120/0x1f0 [btrfs]
        [<ffffffffa0476679>] btrfs_search_slot+0x449/0x930 [btrfs]
        [<ffffffffa048eecf>] btrfs_lookup_inode+0x2f/0xa0 [btrfs]
        [<ffffffffa04eb49c>] __btrfs_update_delayed_inode+0x1c/0x1d0 [btrfs]
        [<ffffffffa04eb9e2>] __btrfs_run_delayed_items+0x162/0x1e0 [btrfs]
        [<ffffffffa04eba63>] btrfs_delayed_inode_exit+0x3/0x20 [btrfs]
        [<ffffffffa0499c63>] btrfs_commit_transaction+0x203/0xa50 [btrfs]
        [<ffffffffa046b519>] btrfs_sync_fs+0x69/0x110 [btrfs]
        [<ffffffff811cb210>] __sync_filesystem+0x30/0x60
        [<ffffffff811cb2bb>] sync_filesystem+0x4b/0x70
    Signed-off-by: default avatarFilipe David Borba Manana <fdmanana@gmail.com>
    Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
    Signed-off-by: default avatarChris Mason <chris.mason@fusionio.com>
    80d94fb3
transaction.c 54 KB