• Vladimir Zapolskiy's avatar
    pwm: lpc32xx: make device usable with common clock framework · 82aff048
    Vladimir Zapolskiy authored
    As a preparatory change for switching LPC32xx mach support to common
    clock framework fix clk_enable/clk_disable calls without matching
    clk_prepare/clk_unprepare.
    
    The driver can not be used on a platform with common clock framework
    until clk_prepare/clk_unprepare calls are added, otherwise clk_enable
    calls will fail and a WARN is generated:
    
        # echo 1 > /sys/bus/platform/drivers/lpc32xx-pwm/4005c000.pwm/pwm/pwmchip0/pwm0/enable
        ------------[ cut here ]------------
        WARNING: CPU: 0 PID: 701 at drivers/clk/clk.c:727 clk_core_enable+0x2c/0xa4()
        Modules linked in: sc16is7xx
        CPU: 0 PID: 701 Comm: sh Tainted: G        W       4.3.0-rc2+ #171
        Hardware name: LPC32XX SoC (Flattened Device Tree)
        Backtrace:
        [<>] (dump_backtrace) from [<>] (show_stack+0x18/0x1c)
        [<>] (show_stack) from [<>] (dump_stack+0x20/0x28)
        [<>] (dump_stack) from [<>] (warn_slowpath_common+0x90/0xb8)
        [<>] (warn_slowpath_common) from [<>] (warn_slowpath_null+0x24/0x2c)
        [<>] (warn_slowpath_null) from [<>] (clk_core_enable+0x2c/0xa4)
        [<>] (clk_core_enable) from [<>] (clk_enable+0x24/0x38)
        [<>] (clk_enable) from [<>] (lpc32xx_pwm_enable+0x1c/0x40)
        [<>] (lpc32xx_pwm_enable) from [<>] (pwm_enable+0x48/0x5c)
        [<>] (pwm_enable) from [<>] (pwm_enable_store+0x5c/0x78)
        [<>] (pwm_enable_store) from [<>] (dev_attr_store+0x20/0x2c)
        [<>] (dev_attr_store) from [<>] (sysfs_kf_write+0x44/0x50)
        [<>] (sysfs_kf_write) from [<>] (kernfs_fop_write+0x134/0x194)
        [<>] (kernfs_fop_write) from [<>] (__vfs_write+0x34/0xdc)
        [<>] (__vfs_write) from [<>] (vfs_write+0xb8/0x140)
        [<>] (vfs_write) from [<>] (SyS_write+0x50/0x90)
        [<>] (SyS_write) from [<>] (ret_fast_syscall+0x0/0x38)
    Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
    Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
    82aff048
pwm-lpc32xx.c 4.33 KB